fix: HMR integration test compiles without pre-built dist - #11
Merged
Conversation
CI runs npm test before npm run build. Match test/run-tests.mjs by compiling src/lattishHmr.tish on demand so hmr-vite.test.mjs does not import a missing dist/lattishHmr.js.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI failure on main after #7 merge:
npm testruns beforenpm run build, buttest/hmr-vite.test.mjsimporteddist/lattishHmr.jswhich does not exist yet.Fix
Compile
src/lattishHmr.tishon demand inside the test (same pattern astest/run-tests.mjs). No CI workflow reordering required.Test plan
rm -rf dist && npm testpasses locally