ci(npm-release): pin npm upgrade to 11.x, not @latest - #16
Merged
Conversation
The v4.0.1 release run failed identically to tishlang/tish's v2.36.1 npm-release run: `npm install -g npm@latest` now resolves to npm 12.0.0, which is independently broken for publishing — its package.json lists `sigstore` in bundleDependencies but the published tarball omits it, and libnpmpublish's publish path requires it unconditionally at module load (even with NPM_CONFIG_PROVENANCE=false, already set here) — every `npm publish` crashes with `Cannot find module 'sigstore'`. Bump the runner to Node 24 (more headroom against future engine-floor bumps) but hold npm at 11.x, matching the fix already applied and locally validated in tishlang/tish (see tishlang/tish#480).
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing "Publish to npm" job in the v4.0.1 release run —
npm publishcrashed with:Not a lattish code change. This is the exact same bug already diagnosed and fixed in
tishlang/tish's own release workflow (tishlang/tish#480):npm install -g npm@latestnow resolves to npm 12.0.0, which is independently broken for publishing — its ownpackage.jsonlistssigstoreinbundleDependencies, but the published tarball doesn't actually contain it.libnpmpublish's publish path requires it unconditionally at module load, so everynpm publishcrashes — regardless of Node version, and regardless ofNPM_CONFIG_PROVENANCE(alreadyfalsein this workflow).Fix
Same fix as tishlang/tish#480: bump the runner to Node 24 (more headroom against future engine-floor bumps) but hold npm at
11.xinstead of floating to@latest/12.x —11.18.0hassigstorebundled correctly, publishes cleanly, and still satisfies this workflow's own>=11.5.1OIDC trusted-publishing requirement.Verify
npm@^11combination was already validated locally end-to-end (realnpm publish --dry-runagainst a throwaway package, provenance off) while fixing ci(npm-release): pin npm upgrade to 11.x, not @latest tish#480 — identical npm version resolution applies here.release: editedto re-trigger (this workflow'son:includesedited).