Fix #113: Use getpass for secret prompts in all auto-collectors - #114
Open
mattiagggg wants to merge 1 commit into
Open
Fix #113: Use getpass for secret prompts in all auto-collectors#114mattiagggg wants to merge 1 commit into
mattiagggg wants to merge 1 commit into
Conversation
…tors Replace input() with getpass.getpass() for secret prompts (tokens, passwords, app secrets) in 4 collector files' setup_config() functions, and add a security note to CONTRIBUTING.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
input()withgetpass.getpass()for secret prompts (tokens, passwords, app secrets) in all auto-collectorsetup_config()functions to prevent credentials from being displayed in plaintext on screen during setup.Changes
getpass.getpass()for the access token promptgetpass.getpass()for app ID and app secret promptsgetpass.getpass()for the bot token promptgetpassfor any secret/credential promptsTesting
python -m compileall tools/— verify no syntax errors across all collector modules--setupand confirm secret fields mask input while non-secret fields (e.g., channel names) still echo normallypython -m unittest discover -s tests— existing tests pass with no regressionsCloses #113