Skip to content

Fix #113: Use getpass for secret prompts in all auto-collectors - #114

Open
mattiagggg wants to merge 1 commit into
titanwings:mainfrom
mattiagggg:fix/issue-113-use-getpass-for-secret-prompts-in
Open

Fix #113: Use getpass for secret prompts in all auto-collectors#114
mattiagggg wants to merge 1 commit into
titanwings:mainfrom
mattiagggg:fix/issue-113-use-getpass-for-secret-prompts-in

Conversation

@mattiagggg

Copy link
Copy Markdown

Summary

Replace input() with getpass.getpass() for secret prompts (tokens, passwords, app secrets) in all auto-collector setup_config() functions to prevent credentials from being displayed in plaintext on screen during setup.

Changes

  • tools/dingtalk_auto_collector.py: Use getpass.getpass() for the access token prompt
  • tools/feishu_auto_collector.py: Use getpass.getpass() for app ID and app secret prompts
  • tools/slack_auto_collector.py: Use getpass.getpass() for the bot token prompt
  • CONTRIBUTING.md: Add security note reminding contributors to use getpass for any secret/credential prompts

Testing

  • python -m compileall tools/ — verify no syntax errors across all collector modules
  • Run each collector with --setup and confirm secret fields mask input while non-secret fields (e.g., channel names) still echo normally
  • python -m unittest discover -s tests — existing tests pass with no regressions

Closes #113

…tors

Replace input() with getpass.getpass() for secret prompts (tokens, passwords, app secrets) in 4 collector files' setup_config() functions, and add a security note to CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use getpass for secret prompts in all auto-collectors

1 participant