Skip to content

fix(plugins): refresh release digest - #148

Merged
titanwings merged 2 commits into
titanwings:distilly-pluginfrom
dajiaohuang:fix/147-refresh-plugin-artifacts
Sep 6, 2026
Merged

fix(plugins): refresh release digest#148
titanwings merged 2 commits into
titanwings:distilly-pluginfrom
dajiaohuang:fix/147-refresh-plugin-artifacts

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Objective / 目标

Restore the documented plugin assembly gate by synchronizing the release manifest and its canonical digest assertion with the current canonical Skill tree.

Fixes #147.

Contract and identity / 合同与基线

  • Base repository/remote, ref, and resolved metadata SHA: titanwings/distilly, distilly-plugin, 5525a4e6adac3e7c1a6c522578513448ae3d7390
  • Remote review head SHA: 0df27f874d7d045b2b9bb0c71569c625e5ef28b4
  • Owning design / issue: plugin assembly contract; [Bug] Generated plugin manifests and release digest are stale #147
  • Rejected alternative and why: changing the assembler or canonical Skill was rejected because the generated digest is deterministic and the defect is stale checked-in metadata, not assembly behavior.

Changes / 变更

  • Regenerate plugins/release-manifest.json from the canonical Skill tree.
  • Update the assembler test's one expected canonical digest.
  • The generated Claude Code and Codex plugin manifest bytes were already current and remain unchanged.

Verification / 验证

Command or check Result Why it covers this diff
python -B scripts/assemble_plugins.py --check PASS Exact generated-byte and mirror verification
focused canonical manifest test PASS, 1 test Verifies release manifest shape, digests, mirrors, and target metadata
safe assembler tests excluding Windows-hostile fixtures PASS, 10 tests + 12 subtests Exercises deterministic assembly and drift checks
python -B scripts/verify_docs.py PASS Confirms generated documentation remains synchronized
pnpm run build PASS Builds the Preview workspace after locked dependency install
pnpm run typecheck PASS Checks all TypeScript package types after build
pnpm run lint PASS Checks repository lint rules
pnpm exec prettier --check plugins/release-manifest.json PASS Checks the changed generated JSON format
git diff --check PASS Checks patch whitespace

Not verified / 未验证

  • Full tests.test_assemble_plugins has four pre-existing native Windows fixture errors: three require symlink privilege and one constructs a POSIX backslash filename that Windows treats as a directory separator. The ten platform-safe tests and the changed golden assertion pass.
  • Repository-wide Prettier reports 351 baseline files because the Windows checkout converts tracked LF files; the changed release manifest passes targeted Prettier.
  • Full pnpm run test reaches 763 passing tests but fails broadly on Windows filesystem semantics (fsync, symlink, rename) and LF-only prompt fixtures. The patch changes no TypeScript/runtime source.

Compatibility, migration, and data impact / 兼容、迁移与数据影响

  • No runtime, wire, storage, dependency, or migration behavior changes.
  • The release manifest now identifies the exact canonical Skill bytes already present on distilly-plugin.

Risks and review focus / 风险与评审重点

  • Review that sha256_d21ddc26d08106708a2a39df44f670d205151529483d59b483c755b07b68901f matches fresh assembler output.

Agent handoff / 交接

  • Status: complete
  • Exact next action: None
  • Local outgoing HEAD SHA: 0df27f874d7d045b2b9bb0c71569c625e5ef28b4
  • Workspace state and pre-existing changes to preserve: independent worktree; no user changes
  • External state: fork branch dajiaohuang:fix/147-refresh-plugin-artifacts; CI pending

Checklist / 检查清单

  • I read the current architecture and owning V3 design chapter
  • Current behavior and target design are not presented as the same thing
  • Docs changed with behavior, and generated chapters were not hand-edited
  • Verification and unverified items above are complete and truthful
  • No secrets, tokens, personal data, or unintended files are committed

@titanwings
titanwings merged commit cf15171 into titanwings:distilly-plugin Sep 6, 2026
@ArmanHosen1

Copy link
Copy Markdown

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Generated plugin manifests and release digest are stale

3 participants