Add Volume Waveform to Timeline #773
Draft
newemka wants to merge 6 commits into
Draft
Conversation
newemka
changed the title
Contributor
|
I think this colour selection is the most pleasing |
Collaborator
Author
|
As asked on discord: "Will it be possible to deactivate those visual representations completely?" |
Contributor
|
Regarding the palette, I think the default should be some gradient across some carefully picked theme colors, so they "work fine" in any theme. Custom hard-coded ones are a very nice addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's still a proof of concept.
I've added a button to TimelineControls.cs, it's using Icon.Stripe4PxPattern
Click this button to switch between Spectrum, Waveform or Both.
I have the feeling that generating the image is too slow compared to generating only the original spectrum.
Maybe some optimisation can be done.
I've tried to find colors that will look okay in any of the default color themes.