Use case-insensitive lookup for Content-Type header#15
Open
Use case-insensitive lookup for Content-Type header#15
Conversation
Author
|
Any update on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse-curl uses a case-sensitive lookup for headers, I discovered a tiny problem with it.
If a curl command includes data e.g.
-d example=true, curl will provide a default'Content-Type': 'application/x-www-form-urlencoded'header, but only if noContent-Type(case-insensitive) header is provided in the command. Currently, parse-curl will add the default header eagerly, even if acontent-typeheader is provided later in the command.This PR fixes the module to follow the behavior of curl. I tried to follow the existing style (it was tempting to modernize).