Conversation
- Added `.envrc` and `.swiftpm/` to `.gitignore` for better environment management. - Enhanced `FileDownloadResponse` to handle case-insensitive header keys for `Content-Disposition` and `Content-Type`, improving robustness in file download scenarios. - Introduced unit tests for `FileDownloadResponse` to validate content type handling and filename extraction, ensuring accurate file metadata retrieval. - Added `FilesHandlerTests` to test file download functionality by record ID, confirming expected behavior and response integrity.
- Cleaned up whitespace in `FileDownloadResponse` for better readability. - Adjusted import order in `FilesHandlerTests` for consistency. - Enhanced assertions in `testDownloadFileByRecordId` to ensure clarity and accuracy. - Added trailing commas in header dictionaries in `FileDownloadModelsTests` for improved syntax consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced
FileDownloadResponseto handle case-insensitive header keys forContent-DispositionandContent-Type, improving robustness in file download scenarios.Introduced unit tests for
FileDownloadResponseto validate content type handling and filename extraction, ensuring accurate file metadata retrieval.Added
FilesHandlerTeststo test file download functionality by record ID, confirming expected behavior and response integrity.Closes TKTC-17 Fix FileDownloadResponse header parsing and Codable conformance issues #15