Skip to content

Proxy resources for MCP apps#167

Open
tleyden wants to merge 4 commits into
mainfrom
proxy_resources
Open

Proxy resources for MCP apps#167
tleyden wants to merge 4 commits into
mainfrom
proxy_resources

Conversation

@tleyden

@tleyden tleyden commented Jul 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • code-rabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e3b3386-d10a-41fc-a5b2-b59151d0446f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch proxy_resources

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds MCP resource proxying for native, core, and plugin resources. The main changes are:

  • Adds native resource interfaces and registry support.
  • Discovers and namespaces plugin resource schemas.
  • Routes resource reads to native, plugin, or core handlers.
  • Advertises resource capabilities and combines resource listings.
  • Adds tests and design notes for resource proxy behavior.

Confidence Score: 5/5

No additional blocking issue qualifies for this follow-up review.

No distinct incomplete fix, unsafe fix, or separate paired failure was found beyond the existing review threads.

T-Rex T-Rex Logs

What T-Rex did

  • Verified that the plugin resources/read route strips the container prefix before forwarding and restores the host-visible prefixed URI in the returned resource content.
  • Router-level and remote-client tests passed, while the broader gateway compile attempt was blocked by a missing local libclang dependency.
  • Before: the router contract assertion received ui://widget-name/index.html; After: the router test passed while asserting both upstream request stripping and downstream response-prefix restoration.
  • Direct remote-client test independently passed the same bidirectional transformation and stale content-length removal.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
crates/core/src/application/mcp_router.rs Adds resource listing, capability advertisement, native and plugin read routing, and response handling.
crates/core/src/application/remote_mcp_container_client.rs Adds plugin resource discovery, URI namespacing, schema rewriting, and proxied resource reads.
crates/core/src/application/native_mcp_tool_registry.rs Extends the native registry with resource registration, lookup, and schema generation.
crates/core/src/ports/native_mcp_resource.rs Defines the native MCP resource interface, content types, and read errors.

Reviews (2): Last reviewed commit: "implement plan to fix resource proxying." | Re-trigger Greptile

Comment thread crates/core/src/application/remote_mcp_container_client.rs
Comment thread crates/core/src/application/mcp_router.rs
Comment thread crates/core/src/application/remote_mcp_container_client.rs
Comment thread crates/core/src/application/mcp_router.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant