Skip to content

Allow plugin containers to propagate env vars#168

Merged
tleyden merged 5 commits into
mainfrom
plugins_env_vars
Jul 16, 2026
Merged

Allow plugin containers to propagate env vars#168
tleyden merged 5 commits into
mainfrom
plugins_env_vars

Conversation

@tleyden

@tleyden tleyden commented Jul 15, 2026

Copy link
Copy Markdown
Owner

In yaml config you can define env vars that will be exposed to the plugin container

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • code-rabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a2f9b00d-4a47-4a3c-bd4a-96371b1ea64f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch plugins_env_vars

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds environment-variable propagation for plugin containers. The main changes are:

  • Parses string, boolean, numeric, and empty YAML environment values.
  • Validates environment-variable names and stores values in plugin configuration.
  • Passes configured values to Docker and macOS containers.
  • Recreates managed plugin containers to apply configuration updates.
  • Adds unit, end-to-end, and documentation coverage.

Confidence Score: 5/5

This looks safe to merge.

Managed containers are recreated with current environment values. Typed YAML scalar values are converted without dropping the plugin entry. No blocking issues found in the changed code.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex ran the requested verification, but its local artifact references were not uploaded.

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
crates/platform/src/config/brain3_yaml.rs Parses and validates plugin environment variables, including typed YAML scalars.
crates/platform/src/container/startup.rs Propagates environment variables and recreates managed containers to apply current configuration.
crates/core/src/domain/model.rs Adds environment variables to the plugin container configuration model.
apps/gateway/tests/e2e_smoke.rs Verifies configured environment values reach a running plugin container.

Reviews (2): Last reviewed commit: "add e2e test" | Re-trigger Greptile

Comment thread crates/platform/src/container/startup.rs
Comment thread crates/platform/src/config/brain3_yaml.rs
@tleyden
tleyden merged commit 3b3ecb2 into main Jul 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant