Feature: Support self-hosted and local S3 instances#1345
Open
AntoineJT wants to merge 11 commits intotlinhart:mainfrom
Open
Feature: Support self-hosted and local S3 instances#1345AntoineJT wants to merge 11 commits intotlinhart:mainfrom
AntoineJT wants to merge 11 commits intotlinhart:mainfrom
Conversation
3b742a4 to
bb8a8f1
Compare
Author
|
@tlinhart Hi, it's been 21 days since I opened this PR Do you want me to change some things? (besides rebasing) Are you accepting new features, or is this app in maintenance-only? |
Owner
|
Hi @AntoineJT and sorry for the radio silence. I appreciate your work and plan to go through it. I was hoping to find some spare time but didn't get to it yet. There are definitely a couple of things I'd like to discuss and possibly change, but overall I think it's a useful feature. Just need more time to delve into it. |
|
this changes looks pretty useful for connecting to local MinIO sever (alternative to S3 for on-premises system) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thank you for your work!
Your project has been useful to me for presenting data to non-technical users, using a local development LocalStack server as an S3 instance.
To achieve this goal, I tinkered a bit with your tool in local.
I figured out it could be useful to other people, so I made the tinkering a real thing by cleaning up my changes and opening this pull request.
Feature
AWS_ENDPOINT_OVERRIDEenvironment variable for overriding endpointAWS_REQUEST_SCHEMEenvironment variable for allowing to choose betweenhttpandhttpsFORCE_PATH_STYLEenvironment variable for enforcing usage of old path-style URLs instead of virtual-hosted-style URLs