Aqua tests: groups agent coverage – part 1#5874
Conversation
- Do not hardcode thread ids in the aqua test runner - Do not hardcode any ships in the `ph-fleet` thread - Minor refactoring
mikolajpp
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9089519224
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ff7083352
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
arthyn
left a comment
arthyn
left a comment
There was a problem hiding this comment.
tests look good. I know you're working on a logging library behind the scenes. we should probably implement that soon since it'd be better if we didn't have to actually run the computation to construct all the dbug log info even if its turned off. in activity we used traps previously to fix that
tlon-apps/desk/app/activity.hoon
Line 126 in 079be48
|
|
||
| A foreign group is a group that we possess some information about, but that we are not a full member of yet. | ||
| ## 4.1 Previewing a group | ||
| A minimal information we can have about a group, apart from knowing its existence, is a group preview. Obtaining a group preview is non-obligatory – we might want to preview groups we have no intention no join. A group preview can be requested of public and private groups without any permissions, while previewing a secret group requires a valid access token. |
There was a problem hiding this comment.
| A minimal information we can have about a group, apart from knowing its existence, is a group preview. Obtaining a group preview is non-obligatory – we might want to preview groups we have no intention no join. A group preview can be requested of public and private groups without any permissions, while previewing a secret group requires a valid access token. | |
| A minimal information we can have about a group, apart from knowing its existence, is a group preview. Obtaining a group preview is non-obligatory – we might want to preview groups we have no intention to join. A group preview can be requested of public and private groups without any permissions, while previewing a secret group requires a valid access token. |
| ``` | ||
|
|
||
| ### Private group ask | ||
| An ask request issued to a private group is recorded in `requests.admissions`, unless the ship has been banned. Group admins can then approve or deny requests. For an approved request, the group host issues a token that is then send to the client. The client then uses the token to join the group. If an ask request has been denied, the group host notifies the client by kicking his subscription, which terminates the flow at the client side. |
There was a problem hiding this comment.
| An ask request issued to a private group is recorded in `requests.admissions`, unless the ship has been banned. Group admins can then approve or deny requests. For an approved request, the group host issues a token that is then send to the client. The client then uses the token to join the group. If an ask request has been denied, the group host notifies the client by kicking his subscription, which terminates the flow at the client side. | |
| An ask request issued to a private group is recorded in `requests.admissions`, unless the ship has been banned. Group admins can then approve or deny requests. For an approved request, the group host issues a token that is then sent to the client. The client then uses the token to join the group. If an ask request has been denied, the group host notifies the client by kicking his subscription, which terminates the flow at the client side. |
| @@ -218,18 +196,16 @@ | |||
| ;< ~ bind:m (redeem-lure-invite ~bud u.cookie lure-invite) | |||
| :: ~bud receives group invites: one current and one backwards compatible | |||
There was a problem hiding this comment.
seems like we just receive one now
There was a problem hiding this comment.
good catch, this comment to be updated.
2 participants
Summary
This PR contains another batch of model-generated aqua tests, as well as various improvements to the tooling and documentation.
Changes
How did I test?
Run aqua tests locally with the runner.
Note: only aqua tests will show up as passing in CI. There is no e2e zod available for 408k yet, so aqua tests use their own set of fakeships.
Risks and impact
Rollback plan
Revert.