fix: add left padding to voice memo recorder#5915
Open
janicduplessis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While recording a voice memo, the recorder had no left padding — the dotted waveform ran flush against the left edge of the sheet, while the right side (timer + stop button) was properly inset.
Changes
AudioRecordernow appliescontentInsetHorizontalaspaddingStartwhile recording too — before, it was only applied during playback, leaving the waveform flush left while recording.The flush-left look was on purpose at the component level — f1dd723ea added
contentInsetHorizontalspecifically to keep the recording waveform flush against the container edge, which presumably made sense for a container whose edge wasn't the screen edge. In the current recorder sheet it is the screen edge, so the waveform running off the edge just looks broken. If flush-left is ever wanted again, callers can passcontentInsetHorizontalper edge — no caller currently sets it.How did I test?
Risks and impact
Rollback plan
Revert this commit.
Screenshots / videos