Open
Conversation
Collaborator
|
@atredennick I like the idea of adding an argument (I say default it to FALSE, no information metric) and produce both the DIC and WAIC if the user wants them. It might also be worth throwing a warning when pD is infinite. |
Author
|
Sounds good @jstudyvin, I agree. I'll add in the option and amend this pull request. |
Author
|
I just added the argument for whether or not to compute WAIC and deviance. I also updated the documentation accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added another
jags.samplecall to calculate WIAC and the deviance of the model, as per https://sourceforge.net/p/mcmc-jags/discussion/610036/thread/8211df61/#ea5c. I was getting some warnings/errors when trying to compute DIC (e.g., pD was infitite). Some Googling suggested WAIC might be better when that happens. Likewise, WAIC seems to be preferred in general over DIC these days.What do you think? We could also make an argument in the
eoarfunction that let's the user decide whether to compute these or not since it is one more sampling step.