fix(creator): FFCreatorCenter cannot customize the fileName - #459
Open
electroluxcode wants to merge 1 commit into
Open
fix(creator): FFCreatorCenter cannot customize the fileName#459electroluxcode wants to merge 1 commit into
electroluxcode wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #326
在这个代码中
FFCreator/lib/conf/conf.js
Line 48 in abbbb11
给outputDir设置了一个默认值,导致了下面的代码每次都会进入
if (this.inCenter && outputDir),这导致了 output 这个变量永远都会被 uuid 设置,从而用户 实例化的 output永远不生效FFCreator/lib/creator.js
Lines 99 to 105 in abbbb11