Skip to content

samlcontent should be decrypted SAML response (sign then encrypt) #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mastermatt wants to merge 6 commits into
base: master
Choose a base branch
from
Open

samlcontent should be decrypted SAML response (sign then encrypt) #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cdd468b
samlcontent should be decrypted SAML response (sign then encrypt)
mastermatt Aug 28, 2025
b439772
Merge branch 'master' into samlcontent-sign-then-encrypt
mastermatt Nov 29, 2025
2c34a57
Call checkSignature is passed in arg
mastermatt Dec 16, 2025
4cfecad
Merge branch 'master' into samlcontent-sign-then-encrypt
mastermatt Dec 16, 2025
4eb0bd6
Merge branch 'master' into samlcontent-sign-then-encrypt
mastermatt Jun 10, 2026
d880728
align variable pattern
mastermatt Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/flow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ async function postFlow(options: FlowOptions): Promise<FlowResult> {
} else if (decryptRequired && !verified) {
// Encrypted assertion, signature is on the assertion itself.
const result = await libsaml.decryptAssertion(self, samlContent);
const decryptedDoc = result[0];
const [decryptedDocVerified, verifiedDecryptedAssertion] = libsaml.verifySignature(decryptedDoc, verificationOptions);
samlContent = result[0];
const [decryptedDocVerified, verifiedDecryptedAssertion] = libsaml.verifySignature(samlContent, verificationOptions);
if (decryptedDocVerified) {
extractorFields = getDefaultExtractorFields(parserType, verifiedDecryptedAssertion);
} else {
Expand Down
3 changes: 1 addition & 2 deletions src/libsaml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,8 +642,7 @@ const libSaml = () => {
}

sig.loadSignature(signatureNode);

verified = sig.checkSignature(doc.toString());
verified = sig.checkSignature(xml);

if (!verified) {
continue;
Expand Down
3 changes: 3 additions & 0 deletions test/flow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ test('send response with signed assertion and parse it', async () => {
expect(typeof id).toBe('string');
expect(samlContent.startsWith('<samlp:Response')).toBe(true);
expect(samlContent.endsWith('/samlp:Response>')).toBe(true);
expect(samlContent).toContain('>user@esaml2.com</saml:NameID>')
expect(extract.nameID).toBe('user@esaml2.com');
expect(extract.response.inResponseTo).toBe('request_id');
});
Expand Down Expand Up @@ -955,6 +956,7 @@ test('send login response with encrypted non-signed assertion and parse it', asy
expect(typeof id).toBe('string');
expect(samlContent.startsWith('<samlp:Response')).toBe(true);
expect(samlContent.endsWith('/samlp:Response>')).toBe(true);
expect(samlContent).toContain('>user@esaml2.com</saml:NameID>')
expect(extract.nameID).toBe('user@esaml2.com');
expect(extract.response.inResponseTo).toBe('request_id');
});
Expand Down Expand Up @@ -1133,6 +1135,7 @@ test('send login response with encrypted non-signed assertion with EncryptThenSi
expect(typeof id).toBe('string');
expect(samlContent.startsWith('<samlp:Response')).toBe(true);
expect(samlContent.endsWith('/samlp:Response>')).toBe(true);
expect(samlContent).toContain('>user@esaml2.com</saml:NameID>')
expect(extract.nameID).toBe('user@esaml2.com');
});

Expand Down