fix: survive transient accept() failures instead of exiting#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_accept()croaked on any accept() failure, so transient errors — fdexhaustion (EMFILE/ENFILE) or a client aborting mid-handshake
(ECONNABORTED) — took the whole daemon down. In production deployments
under fd pressure this turns a momentary resource blip into a full outage.
Now recoverable errno values (EINTR, ECONNABORTED, EAGAIN/EWOULDBLOCK,
EPROTO, EMFILE, ENFILE, ENOBUFS, ENOMEM) get a throttled warning
(new LTC_ACCEPT_FAILURE standalone category, reusing the log-throttling
machinery from #29) and the daemon keeps serving; anything else still
croaks, since remaining accept() errno values indicate programming errors.
Known trade-off: while EMFILE persists the listener stays readable and the
event loop spins; that transient CPU cost is strictly better than exiting,
and a reserve-fd accept-then-close scheme was deliberately left out (YAGNI).
Test plan:
EMFILE — logs the warning, stays alive, keeps serving the existing
connection, and accepts new clients once fds free up