ci: bound job runtime so wedged runners fail fast#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A push run on main recently sat for 15 minutes with all three jobs stuck
(a hosted-runner infrastructure stall — the identical commit passed on
re-run and in its PR run), and without a job timeout such a wedge would
occupy runners for GitHub's default 6 hours before failing.
Normal runs finish in about a minute, so cap the
testmatrix jobs at10 minutes and
sanitizeat 15 (it shows more runner-speed varianceunder ASan). A future infra hiccup now self-terminates and reports
failure promptly instead of hanging.
Test plan
the change end-to-end