refactor: remove dead build_get_request_packet()#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_get_request_packet()lost its only caller when the ber-signed-integerswork deleted test_ber.c's demo hexdump block, leaving only the definition in
ber.cand the declaration insqe.h. It also force-encoded a caller-suppliedrequest id to 4 bytes, making it a latent second copy of the sid-range encoding
invariant — worth removing rather than leaving as a footgun.
This is an internal-only removal with no user-visible effect, so no changelog
fragment.
Test plan
-Werrorbuildmake test, 393 tests)scan-buildstatic analysis: No bugs found