fix: bail from client_input when input buffer reservation fails#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
client_input()fed freshly-read bytes into the connection's msgpack unpackerwithout checking whether the buffer reservation succeeded. On an allocation
failure the reservation returns false, after which the code copied the read data
into a buffer that was never grown — a heap buffer overrun, reachable only under
memory exhaustion.
The read-and-feed logic is now factored into
feed_client_unpacker(), whichreports a failed reservation instead of copying past the buffer.
client_input()tears the connection down via
client_gone()on failure, matching how it alreadyhandles EOF and peer resets.
Why
Under memory pressure a client connection should be dropped cleanly rather than
corrupting the daemon's heap. Surfaced during review of a since-rejected PR that
misdiagnosed the surrounding code but pointed at this real (if minor) gap.
Testing
t/test_msgpack.cexercisesfeed_client_unpacker():a normal chunk feeds and parses; an impossibly large reservation returns
-1 instead of overrunning (this case segfaulted before the fix).
make test— full suite passes (397 tests).scan-build make— "No bugs found".