Added image_url of the first listing image to the output table#43
Open
williamy2k wants to merge 1 commit intotoby-p:masterfrom
Open
Added image_url of the first listing image to the output table#43williamy2k wants to merge 1 commit intotoby-p:masterfrom
williamy2k wants to merge 1 commit intotoby-p:masterfrom
Conversation
Owner
|
Apologies for the delay! This seems like a good idea but I think first I'd like to understand if it slows down the requests by a significant time? If so it would be better to make it optional (as with the Also, I think I'd lean towards scraping all the image urls as a list if possible as it seems like that would have a lot more use cases. Not sure how much more effort that would be... |
|
For what it's worth, I pulled this commit into my own branch and didn't notice any measurable performance impact (it's just another xpath on the pre-scraped HTML). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, as discussed I added retrieving the primary property image. This is my first Github pull request so apologies if I got something wrong, happy to amend.