Conversation
|
Caution Review failedThe pull request is closed. Note
|
| Cohort / File(s) | 변경 사항 요약 |
|---|---|
데이터베이스 스키마 sql/init.sql |
events 및 events_detail 테이블에 button_visible (BOOLEAN NOT NULL)과 button_text (VARCHAR(63) NULL) 컬럼 추가 |
Events 엔티티 및 매퍼 src/main/java/im/toduck/domain/events/events/persistence/entity/Events.java, src/main/java/im/toduck/domain/events/events/common/mapper/EventsMapper.java |
buttonVisible, buttonText 필드 추가, getter/setter 및 업데이트 메서드 구현, 매퍼에서 필드 매핑 |
Events 요청 DTO src/main/java/im/toduck/domain/events/events/presentation/dto/request/EventsCreateRequest.java, src/main/java/im/toduck/domain/events/events/presentation/dto/request/EventsUpdateRequest.java |
buttonVisible, buttonText 필드 추가, 검증 및 스키마 어노테이션 포함, LocalDateTime 역직렬화 지원 추가 |
Events 응답 DTO src/main/java/im/toduck/domain/events/events/presentation/dto/response/EventsResponse.java |
isButtonVisible, buttonText 필드 추가, 스키마 어노테이션 포함 |
Events 서비스 src/main/java/im/toduck/domain/events/events/domain/service/EventsService.java |
updateEvents 메서드에 buttonVisible, buttonText 조건부 업데이트 로직 추가 |
EventsDetail 엔티티 및 매퍼 src/main/java/im/toduck/domain/events/detail/persistence/entity/EventsDetail.java, src/main/java/im/toduck/domain/events/detail/common/mapper/EventsDetailMapper.java |
buttonVisible, buttonText 필드 추가, 업데이트 메서드 구현, 매퍼에서 필드 매핑 |
EventsDetail 요청 DTO src/main/java/im/toduck/domain/events/detail/presentation/dto/request/EventsDetailCreateRequest.java, src/main/java/im/toduck/domain/events/detail/presentation/dto/request/EventsDetailUpdateRequest.java |
buttonVisible, buttonText 필드 추가, 검증 및 스키마 어노테이션 포함 |
EventsDetail 응답 DTO src/main/java/im/toduck/domain/events/detail/presentation/dto/response/EventsDetailResponse.java |
buttonVisible, buttonText 필드 추가, 스키마 어노테이션 포함 |
EventsDetail 서비스 및 저장소 src/main/java/im/toduck/domain/events/detail/domain/service/EventsDetailService.java, src/main/java/im/toduck/domain/events/detail/persistence/repository/querydsl/EventsDetailRepositoryCustomImpl.java |
서비스에서 조건부 업데이트 로직 추가, 저장소에서 명시적 ID 정렬 제거 |
테스트 코드 src/test/java/im/toduck/domain/events/detail/domain/usecase/EventsDetailUseCaseTest.java, src/test/java/im/toduck/domain/events/events/domain/usecase/EventsUseCaseTest.java |
요청 빌더에 buttonVisible, buttonText 메서드 추가, 테스트 픽스처 업데이트 |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
- Main <- Develop #144: 같은 Events, EventsDetail 엔티티, 매퍼, DTO, 서비스 클래스를 수정하므로 직접 관련됨
- fix: 이벤트 디테일 조회 시 이미지 정렬 제거, feat: 이벤트 페이지 버튼 관련 기능 #151: 동일한 스키마 변경과 EventsDetailRepositoryCustomImpl의 정렬 제거를 포함하므로 직접 관련됨
- 소셜 이벤트 기능 구현 #142: PR
#142에서도입된 같은 도메인 클래스들을 수정하므로 관련됨
Suggested labels
✨ Feature
Suggested reviewers
- wafla
- Junad-Park
- jungbk0808
Poem
🐰 버튼들이 새로운 옷을 입네요
보임새와 글귀를 담아 춤추고
이벤트 상세도 함께 따라 물드네
스키마부터 서비스까지 모두 손잡고
우리의 소중한 기능들이 반짝반짝! ✨
✨ Finishing touches
- 📝 Generate docstrings
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
develop
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
sql/init.sqlsrc/main/java/im/toduck/domain/events/detail/common/mapper/EventsDetailMapper.javasrc/main/java/im/toduck/domain/events/detail/domain/service/EventsDetailService.javasrc/main/java/im/toduck/domain/events/detail/persistence/entity/EventsDetail.javasrc/main/java/im/toduck/domain/events/detail/persistence/repository/querydsl/EventsDetailRepositoryCustomImpl.javasrc/main/java/im/toduck/domain/events/detail/presentation/dto/request/EventsDetailCreateRequest.javasrc/main/java/im/toduck/domain/events/detail/presentation/dto/request/EventsDetailUpdateRequest.javasrc/main/java/im/toduck/domain/events/detail/presentation/dto/response/EventsDetailResponse.javasrc/main/java/im/toduck/domain/events/events/common/mapper/EventsMapper.javasrc/main/java/im/toduck/domain/events/events/domain/service/EventsService.javasrc/main/java/im/toduck/domain/events/events/persistence/entity/Events.javasrc/main/java/im/toduck/domain/events/events/presentation/dto/request/EventsCreateRequest.javasrc/main/java/im/toduck/domain/events/events/presentation/dto/request/EventsUpdateRequest.javasrc/main/java/im/toduck/domain/events/events/presentation/dto/response/EventsResponse.javasrc/test/java/im/toduck/domain/events/detail/domain/usecase/EventsDetailUseCaseTest.javasrc/test/java/im/toduck/domain/events/events/domain/usecase/EventsUseCaseTest.java
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings.