Skip to content

feat(tools): Normalized detected shell names to lowercase on Windows #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floitsch merged 1 commit into from
Oct 18, 2025
Merged

feat(tools): Normalized detected shell names to lowercase on Windows #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/export_utils/activate_venv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ def detect_shell(args: Any) -> str:
break
current_pid = parent_pid

return detected_shell_name
# On Windows shell names are case-insensitive, but ESP-IDF defines them in lowercase
return detected_shell_name.lower() if sys.platform == 'win32' else detected_shell_name


@status_message('Detecting outdated tools in system', rv_on_ok=True)
Expand Down