Skip to content

Fix cmpctmalloc crash for large aligned allocations. #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floitsch merged 2 commits into from
Mar 18, 2026
Merged

Fix cmpctmalloc crash for large aligned allocations. #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8abf5e2
Fix cmpctmalloc crash for large aligned allocations.
floitsch Mar 15, 2026
566c8c8
Feedback.
floitsch Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/heap/third_party/dartino/cmpctmalloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,7 +1353,7 @@ IRAM_ATTR void *cmpct_aligned_alloc_impl(cmpct_heap_t *heap, size_t size, size_t

// The page allocator already has the ability to return allocations that
// are more aligned than the page size.
if (alignment >= PAGE_SIZE / 2) {
if (alignment >= PAGE_SIZE / 2 || size >= PAGE_SIZE / 4 * 3) {
// We take 2k (half-page) allocations in here too, because treating them as
// page allocations will waste 2k, but putting them in the normal system
// actually wastes even more.
Expand Down
Loading