Get it working on python 3 and add a path - #3
Open
dkowis wants to merge 5 commits into
Open
Conversation
This allows it to work with things like VictoriaMetrics that speak Prometheus push gateway, but don't follow the same URL path.
These three are the only fields WeeWX puts in a record that had no entry in weather_metrics, so every published record logged three lines of "missing field [x] in defs" -- about 1.5 lines per second of journal noise, and the data was silently not exported. The '# 'windrun':' and '# ET':' comments looked deliberate but were not: usUnits and dateTime carried identical stale comments while being fully mapped further down the table. Dropped those two misleading comments. Units follow target_unit = US, matching the existing naming: ET in inches, windrun in miles. Beaufort is a dimensionless scale. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this, and it's awesome, but I needed to add a path to make promPush work with VictoriaMetrics, as it's got a PromGateway compatible endpoint, but it's at a url prefix.
So I added that, then I ran into all the python 2 vs python 3 problems, so I did those.
This is up and running on my weewx instance :D