Skip to content

Conversation

@bhscer
Copy link
Contributor

@bhscer bhscer commented Jan 14, 2026

Currently in ThemedDivider has some wrong:

  1. There needs to add   in divider, or the divider will has 0 size (maybe there are better ways to do that)
  2. props.className ( usually undefined ) will override the customed className, leding the element to have empty className, so I copied the logics in example

@bhscer bhscer marked this pull request as draft January 14, 2026 18:46
@bhscer bhscer marked this pull request as ready for review January 14, 2026 19:15
@bhscer
Copy link
Contributor Author

bhscer commented Jan 14, 2026

I got a new question, just using the example's styled example, and add border-radius: 30px; in .styled-pane's style, I find the radis of the right element's right side is missing, is that means the width is not correct, or just works as expected?

image

@tomkp
Copy link
Owner

tomkp commented Jan 14, 2026

Thanks for catching the props spread issue — that's a valid fix. However:

  1. The   shouldn't be necessary. The StyledExample.tsx uses a self-closing div without content. The divider dimensions come from the Tailwind classes (w-1/h-1). If you're seeing 0 size, there may be a separate CSS issue.

  2. Please keep the self-closing /> style to match the reference example.

  3. Please add back the semicolon after the closing parenthesis.

@bhscer
Copy link
Contributor Author

bhscer commented Jan 14, 2026

Thanks for catching the props spread issue — that's a valid fix. However:

  1. The   shouldn't be necessary. The StyledExample.tsx uses a self-closing div without content. The divider dimensions come from the Tailwind classes (w-1/h-1). If you're seeing 0 size, there may be a separate CSS issue.
  2. Please keep the self-closing /> style to match the reference example.
  3. Please add back the semicolon after the closing parenthesis.

Ok, I have submit a new commit, which fixs the format problem

@bhscer
Copy link
Contributor Author

bhscer commented Jan 15, 2026

I got a new question, just using the example's styled example, and add border-radius: 30px; in .styled-pane's style, I find the radis of the right element's right side is missing, is that means the width is not correct, or just works as expected?

image

And may I ask you if this is a expected feature or just a bug? Maybe I have find a way to fix it

image

@tomkp
Copy link
Owner

tomkp commented Jan 15, 2026

Thanks for the PR 🙏

Do you want to open this as a separate issue?

#870 (comment)

@tomkp tomkp merged commit a6e5c70 into tomkp:master Jan 15, 2026
1 check passed
@bhscer
Copy link
Contributor Author

bhscer commented Jan 15, 2026

Thanks for the PR 🙏

Do you want to open this as a separate issue?

#870 (comment)

Yes, I have created it: #871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants