fix: account for divider size in pane calculations #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, percentage-based pane sizes were calculated against the full container size, ignoring the space taken by dividers. This caused panes totaling 100% to overflow their container by the combined width of all dividers. Changes: - Add `dividerSize` prop (default: 1px) to SplitPane for accurate sizing - Subtract total divider width from available space before calculating percentage-based pane sizes - Apply same adjustment when redistributing pane sizes on container resize - Update tests to verify correct behavior with divider width accounting Fixes #871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dividerSizeprop (default: 1px) to enable accurate pane size calculationsRoot Cause
Previously, percentage-based pane sizes were calculated against the full container size, ignoring divider space. For example, with 3 panes at 33%/34%/33% and two 8px dividers, the panes would total 100% of 1024px = 1024px, plus 16px of dividers = 1040px total (overflow).
Test Plan
Fixes #871