feat(writer): Implement TomlInteger#1004
Merged
Merged
Conversation
epage
reviewed
Jul 11, 2025
epage
reviewed
Jul 11, 2025
epage
reviewed
Jul 11, 2025
Pull Request Test Coverage Report for Build 16226589326Details
💛 - Coveralls |
epage
reviewed
Jul 11, 2025
epage
reviewed
Jul 11, 2025
- Remove unused _separators field in TomlIntegerFormat - Change as_decimal() et al to accept mut self - TomlInteger contains TomlIntegerFormat
Contributor
Author
|
I'm not familiar with snapbox, so feel free to suggest a different test setup. |
Member
|
tests are failing when |
Contributor
Author
|
Sorry, it should run fine now |
Member
|
For future reference, I prefer people to maintain a PR's commits for how they would like them to look when merged, rather than a commit per PR update. There is value in having and merging multiple commits in a PR that can get lost with squashing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
TomlIntegerandTomlIntegerFormatfollowing the discussion at #812. This supersedes #837.This design should be extensible in case we later decide to support integer separators, custom hexadecimal case, or padding (leading zeroes).