Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Avoid creating new functions at each render pass. Fixes issue #46 .#47

Open
gcazaciuc wants to merge 1 commit intotonyhb:masterfrom
gcazaciuc:gcazaciuc/issue_46
Open

Avoid creating new functions at each render pass. Fixes issue #46 .#47
gcazaciuc wants to merge 1 commit intotonyhb:masterfrom
gcazaciuc:gcazaciuc/issue_46

Conversation

@gcazaciuc
Copy link
Copy Markdown

No description provided.

@gcazaciuc
Copy link
Copy Markdown
Author

gcazaciuc commented Jun 12, 2016

There is a problem on how dependencies are setup that cause the CI failures. Tests pass locally. i will have a look at it, also had similar issues like this when first building the project locally

@mmiller42
Copy link
Copy Markdown

Does this fix the issue with using pure rendering? I'm noticing that every component that uses @ui() in my app re-renders if literally anything changes. I spent some time investigating today and while debugging shouldComponentUpdate I noted that the nextProps.ui is never equal to this.props.ui even when no part of the UI state has been changed.

@gcazaciuc
Copy link
Copy Markdown
Author

Yes it would fix it. In the mean-time I've started out my own local state management solution redux-fractal (https://github.com/gcazaciuc/redux-fractal) which doesn't exhibit this problem.

@mmiller42
Copy link
Copy Markdown

Awesome! Yeah looks like this project isn't being actively maintained, glad to see you've rolled your own. Thanks!

@tonyhb
Copy link
Copy Markdown
Owner

tonyhb commented Oct 5, 2016

Hey! Apologies for being late, super busy at docker. Lemme take a look and
get these merged in if we can :)

On Wed, 5 Oct 2016, 14:01 Matt Miller, notifications@github.com wrote:

Awesome! Yeah looks like this project isn't being actively maintained,
glad to see you've rolled your own. Thanks!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#47 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASsAXzy7Ys85UNNETYnI0w-m82OImQ-ks5qxBAbgaJpZM4Iz3zW
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants