This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Remove $(npm bin) as ./node_modules/.bin is on the path.#73
Open
baerrach wants to merge 1 commit intotonyhb:masterfrom
baerrach:master
Open
Remove $(npm bin) as ./node_modules/.bin is on the path.#73baerrach wants to merge 1 commit intotonyhb:masterfrom baerrach:master
baerrach wants to merge 1 commit intotonyhb:masterfrom
baerrach:master
Conversation
It also fixes running this on windows as $() inside npm scripts spawns a command shell and not a bash shell so it fails the expansion.
Owner
|
Thanks a ton for the feedback and PR! I like this a little better than what we have but I'm a lil skeptical of having relative dirs in my $PATH (call me paranoid about the tiny possibility of it weakening my security). Maybe there's another way around this error? I'll have a think. |
Author
|
I hear you. https://docs.npmjs.com/cli/run-script says
I can't find any alternatives from googling. If your PATH doesn't contain |
ghost
pushed a commit
to AoD-Technologies/react-redux-ui-tools
that referenced
this pull request
Jan 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also fixes running this on windows as $() inside npm scripts spawns a command
shell and not a bash shell so it fails the expansion.