fix(version-bump): fixes version bump issues in builds#41
Merged
Conversation
- Move version bump commit before npm publish to prevent version conflicts - Combine git push operations to avoid race conditions - Ensures package.json has correct version before NPM publish attempt - Fixes intermittent publish failures due to timing issues
- Add 'just pr-prep' command that runs all GitHub PR validation checks locally - Includes: pre-commit hooks, build, test:ci, typecheck, lint, format:check - Update CLAUDE.md to instruct always running 'just pr-prep' before committing - Prevents CI failures by catching issues before pushing to remote
- Test results are generated by CI and pr-prep command - Should not be tracked in version control
🤖 Changeset StatusIs this the right version bump?
How to add a changeset:
Skip release entirely:Add This comment will update automatically when you push changes. |
- Analyzes branch commits and generates PR description from template - Uses GitHub CLI to automatically update PR description - Extracts bug fixes, features, and other changes from commits - Saves to .tmp/pr-description.md and updates via gh pr edit - Handles errors gracefully (no gh, no PR, etc.)
- No need to find PR number explicitly - gh pr view and gh pr edit work without arguments - Add example commands showing usage - Simplifies implementation
- Automatically backs up current PR description to .tmp/pr-description.backup.md - Allows reverting changes if needed using gh pr edit - Documents backup/revert workflow - Provides safety net for PR description updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes GitHub Actions publish-beta workflow race condition causing intermittent NPM publish failures due to version bumps happening after publishing. Adds
just pr-prepcommand to run all CI checks locally before committing, and introduces/proj:generate-pr-descslash command for automated PR description generation from branch commits.Type of Change
Changes Made
Bug Fixes
Fixed publish-beta workflow race condition (
.github/workflows/publish-beta.yml)New Features
Added
just pr-prepcommand (justfile).github/workflows/pr-validation.ymlAdded
/proj:generate-pr-descslash command (.claude/commands/proj/generate-pr-desc.md).tmp/pr-description.backup.mdgh pr edit --body-file .tmp/pr-description.backup.mdOther Enhancements
Version sync (
package.json,package-lock.json)Updated CLAUDE.md (
CLAUDE.md)just pr-prepstep before committingImproved .gitignore (
.gitignore)test-results/directory to prevent tracking generated test artifactsTesting
Testing performed:
just pr-prepsuccessfully with all checks passingChecklist
npm run lintandnpm run formatnpm testRelated Issues
Fixes intermittent publish failures on main branch merges where NPM would reject version publishes due to timing issues in the GitHub Actions workflow.
Additional Notes
Why this matters:
just pr-prepcommand helps catch CI issues locally, saving time and preventing broken builds/proj:generate-pr-desccommand streamlines PR creation by automatically generating descriptions from commits[skip-ci]protection that prevents infinite loopsWorkflow safeguards:
[skip-ci]in commit message prevents triggering another build after version bumpDeveloper experience improvements:
just pr-prepprovides immediate feedback before pushing