Version fix 2#42
Merged
Merged
Conversation
- Remove GitHub App token generation (incorrect approach) - Use standard GITHUB_TOKEN with rulesets bypass permissions - Add RULESET_SETUP.md with official GitHub configuration steps - Remove signed commit requirement (GitHub Actions signs automatically) - This is GitHub's official 2024-2025 recommended approach Configuration required: - Create repository ruleset for main branch - Add github-actions[bot] to bypass list - Set bypass mode to 'Always' for automated releases
…pushes - Updated publish-beta workflow to use ssh-key authentication - Revised RULESET_SETUP.md with correct deploy key configuration - GitHub does not allow github-actions[bot] in bypass lists directly - Deploy key method is simpler than GitHub App approach - Added detailed setup instructions and troubleshooting
🤖 Changeset StatusIs this the right version bump?
How to add a changeset:
Skip release entirely:Add This comment will update automatically when you push changes. |
- Removed GitHub App option (more complex, not chosen) - Consolidated to single deploy key method - Added step-by-step instructions with exact commands - Added rationale for why deploy keys over other methods - Included cleanup step for key files - Ready for replication in other projects
- Version 0.0.44 was already published to NPM - Package.json was out of sync at 0.0.43 - Updated to match published version
- Added specific tool permissions for automated PR description generation - Allows gh CLI, git, and file operations without requiring user approval - Follows pattern from new-feature.md command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the GitHub Actions publish-beta workflow to properly push version bumps back to the protected main branch. The workflow was failing with "Push declined due to repository rule violations" because GitHub does not allow
github-actions[bot]to be added directly to ruleset bypass lists. This PR implements the correct solution using SSH deploy keys with ruleset bypass permissions.Type of Change
Please check the relevant option(s):
Changes Made
Bug Fixes
Fixed GitHub Actions workflow failing to push to protected main branch
github-actions[bot]directly to bypass lists.github/workflows/publish-beta.ymltoken: ${{ secrets.GITHUB_TOKEN }}tossh-key: ${{ secrets.DEPLOY_KEY }}Synced package.json version to match published NPM version
Other Enhancements
Created comprehensive RULESET_SETUP.md documentation
.github/RULESET_SETUP.mdBreaking Changes
None - this is purely a workflow infrastructure fix.
Testing
Testing notes:
Checklist
npm run lintandnpm run formatnpm testRelated Issues
Fixes the workflow failures reported where publish-beta step would fail intermittently with:
Additional Notes
Important Setup Required Before Merge:
This PR requires one-time GitHub configuration (already completed for this repository):
DEPLOY_KEYrepository secretWhy Deploy Keys Over GitHub Apps:
Workflow Safeguards:
[skip-ci]in commit message prevents infinite build loopsFor Future Projects:
Follow
.github/RULESET_SETUP.mdto replicate this setup in other repositories.