User profiles#1
Open
perimetro20 wants to merge 5 commits intospaced_repetitionfrom
Open
Conversation
…y when a new user is created is fully implemented, and tested. Still missing documentation.
Codecov Report
@@ Coverage Diff @@
## spaced_repetition #1 +/- ##
======================================================
+ Coverage 65.77% 78.08% +12.31%
======================================================
Files 22 34 +12
Lines 149 251 +102
======================================================
+ Hits 98 196 +98
- Misses 51 55 +4
Continue to review full report at Codecov.
|
erikiado
requested changes
Feb 1, 2017
erikiado
left a comment
erikiado
left a comment
There was a problem hiding this comment.
check the small changes requested on the code
(best practices python 3)
| owner = models.ForeignKey('user_profiles.Student') | ||
| deck = models.ForeignKey(Deck) | ||
| question = models.CharField(max_length=300) | ||
| answer = models.CharField(max_length=750) |
| home_directory = models.OneToOneField(Folder) | ||
|
|
||
| def __str__(self): | ||
| return '%s' % (self.user) |
…thods for every model are implemented, and they use the .format() function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of a user_profiles app that will be in charge of extending the Django User Model via profiles, which are one_to_one relationships. This pull request if for my implementation of the student profile, which is created automatically when a new user is created, and needs to be assigned a new home_directory.