feat: add room data to websocket - #650
Open
Urantij wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
xd well idk how it was merged with non lint code but ээээто былааа не я не я не я |
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
storycraft
requested changes
Jul 10, 2026
Member
|
example import { type <TYPE> } from './<TYPE>' |
Contributor
Author
|
iam not sure if this is the right thing i needed to do, since some of these imports were not imported as type, but vs code was complaining so idk |
Contributor
Author
|
do i need to resolve this conflict or you just dont have time to move this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will add room model, which exist in memory, when the player is in a ranked play match or just lounge lobby.
This allows to fetch data about users like username, id, country and avatarurl in a current multiplayer room