Skip to content

feat: add room data to websocket - #650

Open
Urantij wants to merge 5 commits into
tosuapp:masterfrom
Urantij:roomom
Open

feat: add room data to websocket#650
Urantij wants to merge 5 commits into
tosuapp:masterfrom
Urantij:roomom

Conversation

@Urantij

@Urantij Urantij commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Will add room model, which exist in memory, when the player is in a ranked play match or just lounge lobby.

This allows to fetch data about users like username, id, country and avatarurl in a current multiplayer room

@Urantij

Urantij commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

xd well idk how it was merged with non lint code but ээээто былааа не я не я не я

@GabuTheDev GabuTheDev added area:memory Regarding readouts from the osu client. area:server The nodejs backend of tosu. labels Jul 5, 2026
@KotRikD

KotRikD commented Jul 10, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: ac5e7678cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@storycraft storycraft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we require all types to be type import when the values are not used. So please change them.

@KotRikD

KotRikD commented Jul 10, 2026

Copy link
Copy Markdown
Member

example

import { type <TYPE> } from './<TYPE>'

@Urantij

Urantij commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

iam not sure if this is the right thing i needed to do, since some of these imports were not imported as type, but vs code was complaining so idk

@Urantij

Urantij commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

do i need to resolve this conflict or you just dont have time to move this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:memory Regarding readouts from the osu client. area:server The nodejs backend of tosu.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants