feat: ingame overlay interact button - #684
Open
storycraft wants to merge 1 commit into
Open
Conversation
storycraft
requested review from
GabuTheDev and
KotRikD
and
a lite review from Copilot
August 5, 2026 07:21
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an “interact” action to the in-game overlay context menu so users can open an overlay’s URL in a separate, interactive window (useful when an overlay’s settings are embedded in the page and not easily adjustable in the offscreen overlay view). It also tweaks Chromium feature flags to address storage behavior for some overlays.
Changes:
- Add a new “interact” context-menu link that opens the selected overlay URL in a new window/tab (
target="_blank"). - Disable Chromium’s
ThirdPartyStoragePartitioningvia--disable-featuresto avoid isolated-storage issues for certain overlays.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ingame-overlay/src/index.ts | Adds a Chromium command-line flag disabling ThirdPartyStoragePartitioning to change storage behavior for overlay content. |
| packages/ingame-overlay/renderer/index.html | Adds an “interact” button that opens the overlay URL in a separate window. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+21
| // disable third party storage partitioning, to avoid issues with overlays using isolated storage | ||
| app.commandLine.appendSwitch( | ||
| 'disable-features', | ||
| 'ThirdPartyStoragePartitioning' | ||
| ); |
Comment on lines
+106
to
+109
| <a class="ctx-button" :href="profile.overlays[context_overlay.index].url" target="_blank"> | ||
| interact | ||
| <i class="icon-link"></i> | ||
| </a> |
GabuTheDev
removed their request for review
August 5, 2026 08:25
Member
|
Removed myself from reviewing. This is a feature I planned for #508 and I am not willing to review anything in the current dashboard. |
Member
Author
|
k |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add interact button to open new interactive window(like obs).
Some overlays embedded settings in page and couldn't adjust settings for ingame overlay.