Bump dependencies - #685
Open
KotRikD wants to merge 1 commit into
Open
Conversation
Member
|
Did you really use Opus 5 to bump some dependencies????????????????????????????????????????? bruh |
Collaborator
|
needed review from @storycraft, since there was a bump of electron dependencies which used by ingame overlay |
storycraft
requested changes
Aug 5, 2026
| "@types/node": "^24.10.4", | ||
| "electron": "^39.2.7", | ||
| "electron-builder": "^26.4.0", | ||
| "electron": "^40.1.0", |
Member
There was a problem hiding this comment.
Electron overlay renderer expect specific version of Electron(defined as peerDependencies). They can introduce breaking changes between major versions. In fact, some previous versions did before.
Member
There was a problem hiding this comment.
I didn't test the build. But if it works without any issues, you can resolve this and ignore.
Member
Yes thank you for noticing this. Because it actually does matter. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR made using AI tools
Claude Opus 5