OPS-4035 - Add missing plugin types + unit tests + readme improvements - #7
Merged
Conversation
Runs the PHPUnit suite against PHP 8.2, 8.3 and 8.4 on pull requests targeting main, with Composer dependency caching. Also adds a workflow status badge to the README. Add description to composer.json for strict validation Opt workflow actions into Node.js 24 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
benfes
previously approved these changes
Jun 10, 2026
benfes
left a comment
benfes
left a comment
There was a problem hiding this comment.
LGTM - some small things, but nothing blocking.
- Pin GitHub Actions to commit SHAs instead of moving tags - Add missing return type to HandlerTest::invoke_static() - Drop never-overridden $name param from make_typed_package() - Add property type declarations for $original_cwd and $original_env Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
codyfinegan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.