Open
Conversation
ldez
suggested changes
Sep 12, 2024
Contributor
ldez
left a comment
There was a problem hiding this comment.
Using the latest version of Go is not required.
The version inside the go.mod is the min Go version and only need to be updated when using specific elements of a Go version.
.github/workflows/go-cross.yml
Outdated
| strategy: | ||
| matrix: | ||
| go-version: [ 1.19, 1.x ] | ||
| go-version: [ 1.23, 1.x ] |
Contributor
There was a problem hiding this comment.
Suggested change
| go-version: [ 1.23, 1.x ] | |
| go-version: [ oldstable, stable ] |
Author
Apply suggestions Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Author
|
@ldez I applied your suggestion :) thank you! |
FlowingSPDG
commented
Sep 12, 2024
Contributor
|
All the following section: Details steps:
# https://github.com/marketplace/actions/setup-go-environment
- name: Set up Go ${{ matrix.go-version }} on ${{ matrix.os }}(${{ matrix.arch }})
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
architecture: ${{ matrix.arch }}
# https://github.com/marketplace/actions/checkout
- name: Checkout code
uses: actions/checkout@v2
# https://github.com/marketplace/actions/cache
- name: Cache Go modules
uses: actions/cache@v3
with:
# In order:
# * Module download cache
# * Build cache (Linux)
# * Build cache (Mac)
# * Build cache (Windows)
path: |
~/go/pkg/mod
~/.cache/go-build
~/Library/Caches/go-build
%LocalAppData%\go-build
key: ${{ runner.os }}-${{ matrix.arch }}-${{ matrix.go-version }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-${{ matrix.arch }}-${{ matrix.go-version }}-go-should be replaced by: steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
architecture: ${{ matrix.arch }} |
Author
|
@ldez Hi, sorry for late response since I was busy! I updated the actions but got |
Contributor
|
Sorry you must remove: and the element related to the matrix. Github action supports only amd64. |
ldez
reviewed
Oct 10, 2024
ldez
reviewed
Oct 10, 2024
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Co-authored-by: Ludovic Fernandez <ldez@users.noreply.github.com>
Author
|
@ldez thank you for code suggestion, applied! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I tried to make a plugin by myself and noticed Go itself and several tools version are old so I updated.
Updated tools
go mod tidy -go=1.23)Updated tool settings
goerr133toerr133fmt.Errorftoerrors.NewOther
Maybe we can use
package plugindemoinstead ofpackage plugindemo_testfordemo_test.gosince golangci-lint detectsdepguardbecause it imports not-test package?