Skip to content

fix(spec): correct Appendix C test vector hash (Issue #18) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrishooooo-netizen merged 1 commit into from
May 28, 2026
Merged

fix(spec): correct Appendix C test vector hash (Issue #18) #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/did-method-trail-v1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,9 +2147,9 @@ Output: did:trail:self:z3KMQXnVKR9qMzkJFfoo9WAYb1A7rdUbEkDCwNWTp6uJX
Input: "ACME Corporation GmbH"
Normalized slug: "acme"
Hash input: "acme:z3KMQXnVKR9qMzkJFfoo9WAYb1A7rdUbEkDCwNWTp6uJX"
SHA-256 (hex): bd70674e4dff8c3a...
trail-hash: "bd70674e4dff8c3a"
Output DID: did:trail:org:acme-bd70674e4dff8c3a
SHA-256 (hex): bd70674e4dffef6e1a54de8b4b78b9fe140f638dfc5b21a239eb48950cc60758
trail-hash: "bd70674e4dffef6e"
Output DID: did:trail:org:acme-bd70674e4dffef6e
```

### 14.4 JCS Canonicalization (RFC 8785)
Expand Down
6 changes: 0 additions & 6 deletions tests/conformance/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,6 @@ These vectors target spec **v1.2.0** (current draft). If you find a vector that
disagrees with a published normative statement of the spec, please open an
issue — the spec is authoritative, the suite is illustrative.

> Known follow-up: Appendix C v1.2.0 shows a truncated/illustrative SHA-256
> example for the org-mode trail-hash; the actual SHA-256 of the documented
> hash input begins `bd70674e4dffef6e…`. The vector at
> `did-creation/valid/02-org-mode-slug-hash.json` uses the actual hash; a spec
> issue will be filed to align Appendix C.

## Adding New Vectors

1. Place a new JSON file under the appropriate scope and `valid/` or `invalid/`
Expand Down
2 changes: 1 addition & 1 deletion tests/conformance/did-creation/invalid/01-wrong-method-name.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"expected": "invalid",
"description": "DIDs MUST start with 'did:trail:'. Any other method prefix (or wrong casing) MUST be rejected.",
"input": {
"did": "did:Trail:org:acme-bd70674e4dff8c3a"
"did": "did:Trail:org:acme-bd70674e4dffef6e"
},
"expectedError": "DID method name MUST be exactly 'did:trail:' (case-sensitive)"
}
2 changes: 1 addition & 1 deletion tests/conformance/did-creation/valid/02-org-mode-slug-hash.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"scope": "did-creation",
"section": "§4.2 org mode + §4.5 normalization",
"expected": "valid",
"description": "Org-mode DID with slug normalization (lowercase, drop legal suffixes) and 16-hex trail-hash suffix derived from SHA-256 of normalized slug + publicKeyMultibase. NOTE: Spec Appendix C v1.2.0 shows truncated hash 'bd70674e4dff8c3a...' which appears to be illustrative; actual SHA-256 of the documented hash input starts with 'bd70674e4dffef6e'. Filed as spec follow-up.",
"description": "Org-mode DID with slug normalization (lowercase, drop legal suffixes) and 16-hex trail-hash suffix derived from SHA-256 of normalized slug + publicKeyMultibase. Matches Appendix C §14.3 test vector (Issue #18).",
"input": {
"mode": "org",
"rawName": "ACME Corporation GmbH",
Expand Down
Loading