Open
Conversation
As they are unused and likely outdated
By setting same features in test & final build
To know that it still works
Default is 360 minutes (6 hours), and stuck workflows dont need to run that long
To align with other names and be more concise
As that, together with "tags" is a AND not a OR.
Collaborator
Author
|
By the way, it is more than a few month again since the last release, and i would say the current state is rather stable, what do you think about releasing another version soon @tramhao ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies some changes with regards to what was discussed in #695.
In detail:
releaseworkflow easier to parse at a glancereleaseworkflow other than actually releasing thingsworkflow_dispatch: manually trigger a run (without releasing), to make sure it actually fully builds and is still validpull_request: make sure it is valid and working when a pull request changes itschedule: make sure it stays valid and builds correctly (once every week)Note that i could not make a broader
pushtest, aspathscombined with eithertagsorbranchescreates a AND condition instead of a OR. (in this case, only triggers a workflow run if a tag is pushed and that tag modified the given files)Additionally, i could not figure out a good way to merge
buildandreleaseyet, but this is still a improvement.