Skip to content

fix(macros): slightly improve unsupported type error message#3856

Merged
abonander merged 1 commit into
transact-rs:mainfrom
dyc3:tweak-error
May 19, 2025
Merged

fix(macros): slightly improve unsupported type error message#3856
abonander merged 1 commit into
transact-rs:mainfrom
dyc3:tweak-error

Conversation

@dyc3

@dyc3 dyc3 commented May 9, 2025

Copy link
Copy Markdown
Contributor

Does your PR solve an issue?

This PR makes a small improvement to the "unsupported type" error message to suggest a potential solution to the user.

I just spent a couple hours on an issue forgetting that type overrides exist and I wished that the message nudged me in that direction.
Perhaps the message could be made even more intelligent.

Is this a breaking change?

No. It's a minor DX improvement.

@abonander

abonander commented May 12, 2025

Copy link
Copy Markdown
Collaborator

I've significantly revised the wording as part of #3383:

There's some significant changes coupled in there, but if you'd like to backport the wording, I wouldn't be against it.

@dyc3

dyc3 commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

Ah, so should I make this PR against that branch instead?

@abonander

Copy link
Copy Markdown
Collaborator

No, I meant that you could copy the wording changes I made in that PR to this one, since that's slated for 0.9.0.

Probably going to have one more patch release before 0.9.0 since we've accumulated a few regressions, so that part could be backported.

@dyc3

dyc3 commented May 13, 2025

Copy link
Copy Markdown
Contributor Author

Oh, ok. Yeah I can do that.

@dyc3

dyc3 commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

This should be ready to go. Let me know if I should do more.

@abonander abonander merged commit 4259862 into transact-rs:main May 19, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants