Skip to content

Add spanning_start and spanning_end#152

Merged
edalzell merged 8 commits intomainfrom
fix/add-spanning-start-end
Apr 17, 2026
Merged

Add spanning_start and spanning_end#152
edalzell merged 8 commits intomainfrom
fix/add-spanning-start-end

Conversation

@marcorieser
Copy link
Copy Markdown
Contributor

@marcorieser marcorieser commented Apr 17, 2026

This PR adds spanning_start and spanning_end to the supplements data. Additionally, it removes the legacy dates key from the calendar return values (they were the same as occurrences).

@github-actions github-actions Bot added the fix label Apr 17, 2026
@marcorieser marcorieser requested a review from edalzell April 17, 2026 14:58
@marcorieser marcorieser self-assigned this Apr 17, 2026
@marcorieser
Copy link
Copy Markdown
Contributor Author

@edalzell I've managed to fix the issue by cloning the object while mapping. Later iterations overwrote the supplements, since it was the same object. I'm not sure if this is the right approach, but it works.

@marcorieser marcorieser marked this pull request as draft April 17, 2026 15:17
@marcorieser marcorieser marked this pull request as ready for review April 17, 2026 15:19
@edalzell edalzell force-pushed the fix/add-spanning-start-end branch from d1b0f98 to 15e4bc1 Compare April 17, 2026 17:50
@edalzell edalzell added feature and removed fix labels Apr 17, 2026
@edalzell edalzell merged commit f4be544 into main Apr 17, 2026
32 checks passed
@edalzell edalzell deleted the fix/add-spanning-start-end branch April 17, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants