Add terragrunt cfg for OmniGCP#343
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage ? 30.12%
=======================================
Files ? 8
Lines ? 664
Branches ? 0
=======================================
Hits ? 200
Misses ? 437
Partials ? 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| gcloud auth, e.g. CloudShell. | ||
| The example command below will generate a public and private note key-pair, using the provided | ||
| witness name, and will use those to create and populate the initial version of two Secret Manager | ||
| secrets called `witness_public_XXX` and `witness_secret_XXX` respectively, where XXX is the name |
There was a problem hiding this comment.
We have code to generate the public key from the private key, and you referenced this in some docs the other day. Did something change that means the public key is now needed here?
There was a problem hiding this comment.
You're right, and I think that's almost always going to be the right answer for recovering the public key in a code setting - and indeed in the first cut of this I dide just throw that line away.
However, I was then thinking about what happens next once someone's spun this up: they need to share the URL and identity with the world, at which point it's less of a technical issue and more just "convenience"; we already have the public key right here, so let's just print it out for the operator to just cut'n'paste. Then I figured that it's just as easy to pop it into somewhere durable so there's no stress if they mess up/forget to do the copy.
The alternative would be to have the omniwitness log the public key into its debug logging, which is fine but then we're asking the opr to go scrobbling in the log vs just storing it in a convenient location.
b515f6a to
fdb7d4d
Compare
fdb7d4d to
13feeed
Compare
This PR adds:
witnessrepo.Towards transparency-dev/witness#386.