Metrics must be on :8080#356
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage ? 30.12%
=======================================
Files ? 8
Lines ? 664
Branches ? 0
=======================================
Hits ? 200
Misses ? 437
Partials ? 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhutchinson
approved these changes
Sep 24, 2025
Contributor
mhutchinson
left a comment
mhutchinson
left a comment
There was a problem hiding this comment.
Can you add something to the PR description about why it must be 8080?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Google Cloud Run default config assumes that all containers are serving metrics on
:8080, so we need to do so.See https://github.com/GoogleCloudPlatform/run-gmp-sidecar?tab=readme-ov-file#create-the-cloud-run-service-default-config for more info.