Point OmniGCP at public witness configs#364
Merged
AlCutter merged 1 commit intoOct 9, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage ? 30.12%
=======================================
Files ? 8
Lines ? 664
Branches ? 0
=======================================
Hits ? 200
Misses ? 437
Partials ? 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhutchinson
reviewed
Oct 9, 2025
| } | ||
|
|
||
| variable "public_witness_config_urls" { | ||
| description = "Set to true if this is a CI/temporary deploy" |
Contributor
There was a problem hiding this comment.
I think this documentation string is... wrong.
Contributor
Author
There was a problem hiding this comment.
Hmm, perhaps it could be improved...
AlCutter
force-pushed
the
omnigcp_public_witness_configs
branch
from
2c95a9f to
e810a65
Compare
mhutchinson
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the OmniGCP instance start fetching the public witness configs and merging them into its known log state in Spanner.
With this, we should now be automatically provisioning new logs added by the public witness networking maintainers to the testing list.