[VIndex] Refactoring and cleaning tech debt#13
Merged
Conversation
mhutchinson
force-pushed
the
refactor
branch
5 times, most recently
from
c22c590 to
d12c24a
Compare
The next milestone is to add the output log. While prototyping this, it became clear that a lot of the naming is confusing. Renamed to make clear what is the input log, what is the write ahead log, etc. This makes space to add the output log parameters etc afterwards. As part of this, simplified the storage flags so that it takes only a root directory and then creates the input and output logs in there, along with the WAL file. Other map persistence will likely be added to this directory too in the future. Use skey->vkey method from formats, and deleted local method. Added a high level test for the verifiable index.
This moves things to be shaped more like a pipleine; the mapper is responsible for reading from the log, verifying the contents, and passing state to build a new map via clear mechanisms. At the moment, this is just the WAL, but the raw log checkpoint will also need to be passed through so that it can make it to the output log. As part of this, a compact range of the currently verified state will also need to be persisted so that we can load that to incrementally verify progress after a restart.
AlCutter
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next milestone is to add the output log. While prototyping this, it became clear that a lot of the naming is confusing. Renamed to make clear what is the input log, what is the write ahead log, etc. This makes space to add the output log parameters etc afterwards.
As part of this, simplified the storage flags so that it takes only a root directory and then creates the input and output logs in there, along with the WAL file. Other map persistence will likely be added to this directory too in the future.
Use skey->vkey method from formats, and deleted local method.
Added a high level test for the verifiable index.