[Vindex] WalWriter improvements#15
Merged
Merged
Conversation
Changed to use a factory method Changed validation to allow truncating any trailing junk after the last newline. This makes it more tolerant when recovering from a partial fsync during a previous write. It also demonstrates that we can truncate the file, which will be useful in the next PR. When ingesting entries from the log, we want to ensure that they match the input log checkpoint commitment. To do this, we will construct a compact range while performing all of the mappings. The WAL will be written as soon as information is available, and periodically we will write the compact range and tree size to disk. This means that on recovery, we may need to throw away any entries in the WAL that are beyond this compact range commitment. This is where truncation will be needed, and this validation code will be provided with an index to truncate everything after.
AlCutter
approved these changes
Jul 30, 2025
Contributor
AlCutter
left a comment
AlCutter
left a comment
There was a problem hiding this comment.
LGTM % the missing err check in the test.
AlCutter
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactorings:
Changed validation to allow truncating any trailing junk after the last
newline. This makes it more tolerant when recovering from a partial
fsync during a previous write.
It also demonstrates that we can truncate the file, which will be useful
in the next PR. When ingesting entries from the log, we want to ensure
that they match the input log checkpoint commitment. To do this, we will
construct a compact range while performing all of the mappings. The WAL
will be written as soon as information is available, and periodically we
will write the compact range and tree size to disk. This means that on
recovery, we may need to throw away any entries in the WAL that are
beyond this compact range commitment. This is where truncation will be
needed, and this validation code will be provided with an index to
truncate everything after.