Skip to content

feat(android): add responsive landscape settings dialog - #58

Open
ryancooper73 wants to merge 2 commits into
tranvuongquocdat:mainfrom
ryancooper73:codex/android-landscape-settings
Open

ryancooper73 wants to merge 2 commits into
tranvuongquocdat:mainfrom
ryancooper73:codex/android-landscape-settings

Conversation

@ryancooper73

Copy link
Copy Markdown

Description

Adds an orientation-specific Android settings layout so the existing portrait list remains unchanged while landscape uses two grouped columns. Done and Disconnect stay in a fixed footer and remain available without scrolling.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement

Related Issue

None.

Changes Made

  • Add a layout-land settings dialog with separate Stats Overlay and Settings Button columns
  • Keep Done and Disconnect in a non-scrolling bottom action bar
  • Reinflate an open settings dialog after orientation changes
  • Use 48dp directional targets with semantic accessibility descriptions
  • Add regression tests for column scrolling, action placement, runtime ID parity, accessibility, and rotation refresh behavior

Testing

  • Tested on macOS [version]
  • Tested on Android [Xiaomi 25079RPDCG, Android 16 / HyperOS 3]
  • Tested USB connection
  • Tested streaming performance

Commands run:

./gradlew testDebugUnitTest assembleDebug
ktlint app/src/main/java/**/*.kt app/src/test/java/**/*.kt

The debug APK was installed successfully over ADB on the attached 3008 x 1880 tablet.

Screenshots (if applicable)

Not included.

Checklist

  • My code follows the project coding standards
  • I have tested my changes thoroughly
  • I have updated documentation if needed
  • My changes do not introduce new warnings
  • I have added comments for complex logic

Additional Notes

Portrait continues to use the existing layout resource. Android selects the new two-column resource only in landscape, and each column can scroll independently on constrained heights while the action footer remains fixed.

@vercel

vercel Bot commented Aug 22, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the tranvuongquocdat2-7001's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant