build!: bump tree-sitter core v0.25.1 → v0.26.6#51
Open
DeusData wants to merge 1 commit into
Open
Conversation
Update tree-sitter submodule to v0.26.6 and re-vendor lib/src and lib/include via copy.sh. BREAKING CHANGE: Remove deprecated functions that called C APIs removed in tree-sitter 0.26: - Parser.TimeoutMicros, Parser.SetTimeoutMicros - Parser.CancellationFlag, Parser.SetCancellationFlag - Language.Version (use Language.AbiVersion instead) - QueryCursor.SetTimeoutMicros, QueryCursor.TimeoutMicros These were all marked @deprecated with "will be removed in 0.26" and have existing replacements (ParseWithOptions/MatchesWithOptions with ProgressCallback, and Language.AbiVersion respectively). Rewrite Parser.ParseCtx to use ParseWithOptions progress callback instead of CancellationFlag (eliminates goroutine and atomic ops). Fix memory leak in ParseWithOptions: pointer.Save(options) had no matching pointer.Unref, leaking per call with non-nil options. Update test fixtures for v0.26 changes: - parser_test.go: tree-sitter crate path cli/ → crates/cli/ - query_test.go: adjust error caret position (column calc change) Supersedes tree-sitter#47 (Dependabot submodule-only bump that failed CI because Go bindings were not updated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update tree-sitter submodule to v0.26.6 and re-vendor
lib/srcandlib/includeviacopy.sh.Breaking changes
Remove deprecated functions that called C APIs removed in tree-sitter 0.26:
Parser.TimeoutMicros,Parser.SetTimeoutMicrosParser.CancellationFlag,Parser.SetCancellationFlagLanguage.Version(useLanguage.AbiVersioninstead)QueryCursor.SetTimeoutMicros,QueryCursor.TimeoutMicrosThese were all marked
@deprecatedwith "will be removed in 0.26" and have existing replacements (ParseWithOptions/MatchesWithOptionswithProgressCallback, andLanguage.AbiVersionrespectively).Other changes
Parser.ParseCtxto useParseWithOptionsprogress callback instead ofCancellationFlag(eliminates goroutine and atomic ops)ParseWithOptions:pointer.Save(options)had no matchingpointer.Unref, leaking per call with non-nil options. Fixed in all fourParseWithOptionsvariants.parser_test.go: tree-sitter crate pathcli/→crates/cli/query_test.go: adjust error caret position (column calculation change)Not included (follow-up PRs)
New C functions added in v0.26 (
ts_point_edit,ts_range_edit, query cursor range methods) are intentionally left unwrapped — they can be added in a follow-up PR to keep this one focused on the core upgrade.Supersedes
Supersedes #47 (Dependabot submodule-only bump that failed CI because Go bindings were not updated).
Test plan
go build ./...— compiles cleango test -race ./...— all tests passgo vet ./...— no warnings