Skip to content

fix: Unify pollHttp behavior across platforms #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
treeform merged 5 commits into from
Apr 6, 2026
Merged

fix: Unify pollHttp behavior across platforms #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71d5fe4
fix: Unify usage of `windyUseStdHttp` for all platforms
heysokam Apr 3, 2026
812ddb1
fix: Add missing `windyUseStdHttp` for the `emscripten` platform
heysokam Apr 3, 2026
b7cf1c6
fix: Unify `windyUseStdHttp` behavior by removing it from linux
heysokam Apr 3, 2026
2b773b0
Merge branch 'master' into heysokam/pollHttp
heysokam Apr 6, 2026
5ea6af0
fix: Missing `pollHttp` declaration/definition error on windows
heysokam Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/windy/platforms/linux/x11.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,8 +1295,7 @@ proc pollEvents*() =
for window in windows:
pollEvents(window)

when defined(windyUseStdHttp):
pollHttp()
pollHttp()

proc closeIme*(window: Window) =
discard
Expand Down
11 changes: 5 additions & 6 deletions src/windy/platforms/win32/platform.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2393,6 +2393,10 @@ elif compileOption("threads"):
if state.onOpenCalled and state.onClose != nil:
state.onClose()

proc pollHttp*() =
## Polling for HTTP requests happens in the main windows loop.
discard

proc pollEvents*() =
# Draw first (in case a message closes a window or similar)
for window in windows:
Expand Down Expand Up @@ -2474,12 +2478,7 @@ proc pollEvents*() =
if (GetKeyState(VK_RSHIFT) and KF_UP) == 0:
activeWindow.handleButtonRelease(KeyRightShift)

when defined(windyUseStdHttp):
pollHttp()

proc pollHttp*() =
## Polling for HTTP requests happens in the main windows loop.
discard
pollHttp()

proc forceMousePos*(window: Window, mousePos: IVec2) =
## Forces mouse position to a place.
Expand Down
Loading