joyent/node-triton#89 -o field,field,...` should be strict about allo…#4
Open
YangYong3 wants to merge 2 commits intotrentm:masterfrom
Open
joyent/node-triton#89 -o field,field,...` should be strict about allo…#4YangYong3 wants to merge 2 commits intotrentm:masterfrom
YangYong3 wants to merge 2 commits intotrentm:masterfrom
Conversation
…about allowed fields
bahamas10
reviewed
Mar 9, 2017
lib/tabula.js
Outdated
| } catch (e) {} | ||
| } catch (e) { | ||
| if (options.caseInsensitiveLookup) | ||
| throw new Error(e); |
Contributor
There was a problem hiding this comment.
since e is already an error, you shouldn't need the new Error constructor, ie.
if (options.caseInsensitiveLookup)
throw e;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TritonDataCenter/node-triton#89